liyafan82 commented on a change in pull request #9151:
URL: https://github.com/apache/arrow/pull/9151#discussion_r583484237
##########
File path: java/vector/src/main/codegen/templates/StructWriters.java
##########
@@ -184,6 +189,41 @@ public ListWriter list(String name) {
return writer;
}
+ @Override
+ public MapWriter map(String name) {
+ return map(name, false);
+ }
+
+ @Override
+ public MapWriter map(String name, boolean keysSorted) {
+ FieldWriter writer = fields.get(handleCase(name));
+ if(writer == null) {
+ ValueVector vector;
+ ValueVector currentVector = container.getChild(name);
+ MapVector v = container.addOrGet(name,
+ new FieldType(addVectorAsNullable,
+ new ArrowType.Map(keysSorted)
+ ,null, null),
+ MapVector.class);
+ writer = new PromotableWriter(v, container,
getNullableStructWriterFactory());
+ vector = v;
+ if (currentVector == null || currentVector != vector) {
+ if(this.initialCapacity > 0) {
+ vector.setInitialCapacity(this.initialCapacity);
+ }
+ vector.allocateNewSafe();
+ }
+ writer.setPosition(idx());
+ fields.put(handleCase(name), writer);
+ } else {
+ if (writer instanceof PromotableWriter) {
Review comment:
no need for a nested `if` statement, just use `else if`?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
