alamb commented on a change in pull request #9600:
URL: https://github.com/apache/arrow/pull/9600#discussion_r584779892
##########
File path: rust/datafusion/src/execution/context.rs
##########
@@ -589,6 +598,10 @@ impl ContextProvider for ExecutionContextState {
fn get_aggregate_meta(&self, name: &str) -> Option<Arc<AggregateUDF>> {
self.aggregate_functions.get(name).cloned()
}
+
+ fn get_config(&self) -> ExecutionConfig {
+ self.config.clone()
+ }
Review comment:
I wonder if there is any reason to copy the config or if the code could
return a reference (and the caller could `clone()` it if they needed to
```suggestion
fn config(&self) -> &ExecutionConfig {
self.config
}
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
