wqc200 commented on a change in pull request #9600:
URL: https://github.com/apache/arrow/pull/9600#discussion_r593738121
##########
File path: rust/datafusion/src/sql/planner.rs
##########
@@ -963,7 +983,12 @@ impl<'a, S: ContextProvider> SqlToRel<'a, S> {
.collect::<Result<Vec<Expr>>>()?
};
+ if let CaseStyle::LikePostgreSQL = case_style {
+ input_name = input_name.to_uppercase();
Review comment:
If we used to_LowerCase, many of the test cases would fail, such as the
test case below:
#[tokio::test]
async fn count_basic() -> Result<()> {
let results = execute("SELECT COUNT(c1), COUNT(c2) FROM test",
1).await?;
assert_eq!(results.len(), 1);
let expected = vec![
"+-----------+-----------+",
"| COUNT(c1) | COUNT(c2) |",
"+-----------+-----------+",
"| 10 | 10 |",
"+-----------+-----------+",
];
assert_batches_sorted_eq!(expected, &results);
Ok(())
}
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
