XiangpengHao commented on PR #6062: URL: https://github.com/apache/arrow-rs/pull/6062#issuecomment-2228738382
Thank you @2010YOUY01 , the PR looks good to me, left a minor comment. Not related to this PR, but I wonder if we should also add `LargeString` support for csv. Some thoughts on reusing the buffer: CSV is row format, making it difficult to reuse the underlying buffer because we will likely hold the entire file in memory. So I think it makes sense to copy the strings to new place. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
