wgtmac commented on code in PR #43268:
URL: https://github.com/apache/arrow/pull/43268#discussion_r1679677866
##########
cpp/src/parquet/properties.h:
##########
@@ -1088,6 +1103,7 @@ class PARQUET_EXPORT ArrowWriterProperties {
bool use_threads_;
::arrow::internal::Executor* executor_;
+ bool time_is_adjusted_to_utc_;
Review Comment:
Do we need the flexibility to specify it by column?
##########
cpp/src/parquet/arrow/schema.cc:
##########
@@ -382,18 +382,18 @@ Status FieldToNode(const std::string& name, const
std::shared_ptr<Field>& field,
break;
case ArrowTypeId::TIME32:
type = ParquetType::INT32;
- logical_type =
- LogicalType::Time(/*is_adjusted_to_utc=*/true,
LogicalType::TimeUnit::MILLIS);
+ logical_type =
LogicalType::Time(arrow_properties.time_is_adjusted_to_utc(),
Review Comment:
Unlike the `TIMESTAMP` type, `TIME32` and `TIME64` types do not carry
timezone info. Therefore reading a `Time32Array` back has no way to warn the
reader that values are not adjusted to UTC in the parquet file.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
