wgtmac commented on code in PR #43268: URL: https://github.com/apache/arrow/pull/43268#discussion_r1686717539
########## cpp/src/parquet/arrow/schema.cc: ########## @@ -382,18 +382,18 @@ Status FieldToNode(const std::string& name, const std::shared_ptr<Field>& field, break; case ArrowTypeId::TIME32: type = ParquetType::INT32; - logical_type = - LogicalType::Time(/*is_adjusted_to_utc=*/true, LogicalType::TimeUnit::MILLIS); + logical_type = LogicalType::Time(arrow_properties.time_is_adjusted_to_utc(), Review Comment: I have the same feeling that it makes no sense. Perhaps we should deprecate the flag on the parquet side? TBH, I'm not very clear on its use case, though the discussion in the issue and the DuckDB implementation seems provide some (valid) use cases. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@arrow.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org