etseidl commented on code in PR #6068:
URL: https://github.com/apache/arrow-rs/pull/6068#discussion_r1681791064
##########
parquet/src/file/page_index/index_reader.rs:
##########
@@ -109,7 +146,13 @@ pub fn read_pages_locations<R: ChunkReader>(
.collect()
}
-pub(crate) fn decode_offset_index(data: &[u8]) -> Result<Vec<PageLocation>,
ParquetError> {
+pub(crate) fn decode_offset_index(data: &[u8]) -> Result<OffsetSizeIndex,
ParquetError> {
+ let mut prot = TCompactSliceInputProtocol::new(data);
Review Comment:
Yes, there is duplication, but I think
`read_pages_locations/decode_page_locations` will now only be called in test
code. My next PR is to switch over to `read_offset_index` everywhere and
deprecate the versions that only read the `PageLocations`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@arrow.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
