nealrichardson commented on code in PR #43351: URL: https://github.com/apache/arrow/pull/43351#discussion_r1686458724
########## r/src/arrow_cpp11.h: ########## @@ -148,7 +148,7 @@ inline SEXP utf8_strings(SEXP x) { for (R_xlen_t i = 0; i < n; i++, ++p_x) { SEXP s = *p_x; - if (s != NA_STRING) { + if (s != NA_STRING && ALTREP(s)) { Review Comment: I guess I don't understand what's happening in here. L144 says that this should no longer be altrep by the time we get here. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@arrow.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org