rok commented on pull request #9606: URL: https://github.com/apache/arrow/pull/9606#issuecomment-790159420
> Thanks for doing this. Can you add tests on the C++ side? I expect tests for `IsIn` and `IndexIn`, with non-trivial dictionary arrays, also in cases where not all dictionary values are referred by indices. Added for string and float32 types. Should we check more? ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
