rok commented on a change in pull request #9606:
URL: https://github.com/apache/arrow/pull/9606#discussion_r587790691
##########
File path: cpp/src/arrow/compute/kernels/scalar_set_lookup_test.cc
##########
@@ -72,6 +72,27 @@ void CheckIsInChunked(const std::shared_ptr<ChunkedArray>&
input,
AssertChunkedEqual(*expected, *actual);
}
+void CheckIsInDictionary(const std::shared_ptr<DataType>& type,
+ const std::shared_ptr<DataType>& index_type,
+ const std::string& input_dictionary_json,
+ const std::string& input_index_json,
+ const std::string& value_set_json,
+ const std::string& expected_json, bool skip_nulls =
false) {
+ auto dict_type = dictionary(index_type, type);
+ auto indices = ArrayFromJSON(index_type, input_index_json);
+ auto dict = ArrayFromJSON(type, value_set_json);
Review comment:
Ugh, thanks for catching that. Fixed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
