ovr commented on a change in pull request #9232:
URL: https://github.com/apache/arrow/pull/9232#discussion_r587848244
##########
File path: rust/datafusion/src/physical_plan/group_scalar.rs
##########
@@ -22,10 +22,12 @@ use std::convert::{From, TryFrom};
use crate::error::{DataFusionError, Result};
use crate::scalar::ScalarValue;
+use arrow::datatypes::Decimal128Type;
/// Enumeration of types that can be used in a GROUP BY expression
#[derive(Debug, PartialEq, Eq, Hash, Clone)]
pub(crate) enum GroupByScalar {
+ Decimal128(i128, usize, usize),
Review comment:
> your goal is to implement the Decimal128 and Decimal256 types
right. In this PR only `Decimal128 `, `Decimal256 ` will be in next PR
##########
File path: rust/datafusion/src/physical_plan/group_scalar.rs
##########
@@ -22,10 +22,12 @@ use std::convert::{From, TryFrom};
use crate::error::{DataFusionError, Result};
use crate::scalar::ScalarValue;
+use arrow::datatypes::Decimal128Type;
/// Enumeration of types that can be used in a GROUP BY expression
#[derive(Debug, PartialEq, Eq, Hash, Clone)]
pub(crate) enum GroupByScalar {
+ Decimal128(i128, usize, usize),
Review comment:
> your goal is to implement the Decimal128 and Decimal256 types
right. In this PR only `Decimal128 `, `Decimal256 ` will be in the next PR
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
