samuelcolvin commented on code in PR #6211:
URL: https://github.com/apache/arrow-rs/pull/6211#discussion_r1712194620


##########
arrow-cast/src/parse.rs:
##########
@@ -1425,6 +1431,33 @@ fn parse_interval_components(
     Ok(result.collect::<Vec<_>>())
 }
 
+/// Split an interval into a vec of amounts and units.
+///
+/// Pairs are separated by spaces, but within a pair the amount and unit may 
or may not be separated by a space.
+///
+/// This should match the behavior of PostgreSQL's interval parser.
+fn split_interval_components(value: &str) -> Vec<(&str, Option<&str>)> {

Review Comment:
   Can do, but I think it'll make the code significantly more verbose, I'm not 
sure that's necessary for code that should only be called once per query.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscr...@arrow.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to