Michael-J-Ward commented on code in PR #6216:
URL: https://github.com/apache/arrow-rs/pull/6216#discussion_r1716263739
##########
parquet/tests/arrow_writer_layout.rs:
##########
@@ -189,7 +189,7 @@ fn test_primitive() {
pages: (0..8)
.map(|_| Page {
rows: 250,
- page_header_size: 36,
+ page_header_size: 38,
Review Comment:
These sizes changed upon switching `ValueStatistic::null_count` from `u64`
to `Option<u64>`.
Although I'd expect such a change to require an extra bit, I was still
concerned that these sizes might be set by the parquet spec, and so called it
out.
https://github.com/apache/arrow-rs/pull/6216#pullrequestreview-2229709079
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@arrow.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
