Michael-J-Ward commented on code in PR #6216:
URL: https://github.com/apache/arrow-rs/pull/6216#discussion_r1717040146
##########
parquet/tests/arrow_writer_layout.rs:
##########
@@ -189,7 +189,7 @@ fn test_primitive() {
pages: (0..8)
.map(|_| Page {
rows: 250,
- page_header_size: 36,
+ page_header_size: 38,
Review Comment:
Scratch the above. The answer is in the linked comment.
When I initially converted `null_count` to `Option<64>`, the *first* test I
updated `test_memory_size`, and incorrectly assume the rest of the layout tests
were downstream of that one.
https://github.com/apache/arrow-rs/pull/6216#discussion_r1716983500
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
