jiachengdb commented on code in PR #6230:
URL: https://github.com/apache/arrow-rs/pull/6230#discussion_r1718677041
##########
object_store/src/aws/builder.rs:
##########
@@ -813,6 +827,16 @@ impl AmazonS3Builder {
self
}
+ /// Use SSE-C for server side encryption.
+ pub fn with_ssec_encryption(mut self, customer_key_base64: impl
Into<String>) -> Self {
Review Comment:
Good catch.
My intention is to make this API takes an already base64 encoded key.
The reason is because I checked the AWS SDK examples in
https://docs.aws.amazon.com/AmazonS3/latest/userguide/ServerSideEncryptionCustomerKeys.html,
that's what they do for the .NET API.
<img width="880" alt="image"
src="https://github.com/user-attachments/assets/7f30a07a-6ed2-4ef9-8b2c-a5f2e9db5037";>
So now I removed the base64 encoding inside this method, and changed the
test to encode first.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
