jiachengdb commented on code in PR #6230:
URL: https://github.com/apache/arrow-rs/pull/6230#discussion_r1718678275
##########
object_store/src/aws/builder.rs:
##########
@@ -813,6 +827,16 @@ impl AmazonS3Builder {
self
}
+ /// Use SSE-C for server side encryption.
+ pub fn with_ssec_encryption(mut self, customer_key_base64: impl
Into<String>) -> Self {
+ self.encryption_type =
Some(ConfigValue::Parsed(S3EncryptionType::SseC));
+ if let Some(customer_key_64) = customer_key_base64.into().into() {
+ self.encryption_customer_key_base64 =
+ Some(BASE64_STANDARD.encode(customer_key_64.clone()));
+ }
Review Comment:
I added the `if` mainly following other examples in this file like
`with_dsse_kms_encryption`.
I've now removed the `if`. Still not sure why the other places need the `if`
though.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@arrow.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
