zeroshade commented on code in PR #43679:
URL: https://github.com/apache/arrow/pull/43679#discussion_r1718679751
##########
go/parquet/metadata/app_version.go:
##########
@@ -164,7 +164,7 @@ func (v AppVersion) HasCorrectStatistics(coltype
parquet.Type, logicalType schem
// parquet-cpp-arrow version 4.0.0 fixed Decimal comparisons for
creating min/max stats
// parquet-cpp also becomes parquet-cpp-arrow as of version 4.0.0
if v.App == "parquet-cpp" || (v.App == "parquet-cpp-arrow" &&
v.LessThan(parquet1655FixedVersion)) {
- if _, ok := logicalType.(*schema.DecimalLogicalType); ok &&
coltype == parquet.Types.FixedLenByteArray {
+ if _, ok := logicalType.(schema.DecimalLogicalType); ok &&
coltype == parquet.Types.FixedLenByteArray {
Review Comment:
why did this change?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@arrow.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
