nealrichardson commented on pull request #9483: URL: https://github.com/apache/arrow/pull/9483#issuecomment-792322123
I tried bumping boost to the latest (1.75.0), and that does successfully download from sourceforge. However, the build fails because of Thrift 0.12's use of deprecated boost endian headers (cf. https://issues.apache.org/jira/browse/THRIFT-4836), which were [removed in boost 1.73.0](https://github.com/boostorg/endian/issues/45). This was apparently [fixed in Thrift 0.13](https://issues.apache.org/jira/browse/THRIFT-4861). I see three options: 1. [Upgrade to thrift 0.13](https://issues.apache.org/jira/browse/ARROW-8049) to allow newer boost. This was stalled before because thrift 0.13 apparently requires newer cmake than we do. https://issues.apache.org/jira/browse/THRIFT-5137 is the issue we created about that. It looks like an easy fix, which we could then apply as a patch step in our cmake build to allow 0.13. 2. Apply the patch from THRIFT-4861 in our build_thrift cmake macro and keep going with thrift 0.12 while allowing us to upgrade to newer boost. 3. Bump boost only to 1.72, the last version before the deprecated headers were removed, and don't bother with thrift. IMO option 1 is best; I think thrift 0.13 also uses even less boost than 0.12, so we could prune our boost bundle further. And I suspect it only requires a very small change. Option 3 is the least effort but just defers the maintenance burden. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
