pitrou commented on PR #43601: URL: https://github.com/apache/arrow/pull/43601#issuecomment-2304114674
I took a quick look and here are some assorted thoughts: * there are no unit tests * only the encryption key needs to be on S3Options, not the MD5 and algorithm string (which can be computed on the fly) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
