ripplehang commented on PR #43601: URL: https://github.com/apache/arrow/pull/43601#issuecomment-2306583164
> I took a quick look and here are some assorted thoughts: @pitrou Thanks for your review, for #1, i would try to add ut for the change, for #2, yes, actually ONLY the Key is needed, that's why i only expose one SetSSECKey function, and three Get function, and private the new added datamember. do you suggest to only add one datamember for S3Options? but if there is only one memeber, we may needs to calculate everywhere? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
