ripplehang commented on code in PR #43601:
URL: https://github.com/apache/arrow/pull/43601#discussion_r1741405242
##########
cpp/src/arrow/filesystem/s3fs.cc:
##########
@@ -1433,11 +1455,12 @@ bool IsDirectory(std::string_view key, const
S3Model::HeadObjectResult& result)
class ObjectInputFile final : public io::RandomAccessFile {
public:
ObjectInputFile(std::shared_ptr<S3ClientHolder> holder, const io::IOContext&
io_context,
- const S3Path& path, int64_t size = kNoSize)
+ const S3Path& path, int64_t size = kNoSize, const
std::string& c_key = "")
: holder_(std::move(holder)),
io_context_(io_context),
path_(path),
- content_length_(size) {}
+ content_length_(size),
+ sse_customer_key(c_key) {}
Review Comment:
ok, I would refine.
##########
cpp/src/arrow/filesystem/s3fs.cc:
##########
@@ -1433,11 +1455,12 @@ bool IsDirectory(std::string_view key, const
S3Model::HeadObjectResult& result)
class ObjectInputFile final : public io::RandomAccessFile {
public:
ObjectInputFile(std::shared_ptr<S3ClientHolder> holder, const io::IOContext&
io_context,
- const S3Path& path, int64_t size = kNoSize)
+ const S3Path& path, int64_t size = kNoSize, const
std::string& c_key = "")
Review Comment:
ok, I would refine.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
