lidavidm commented on code in PR #43903:
URL: https://github.com/apache/arrow/pull/43903#discussion_r1741576866
##########
java/memory/memory-core/src/main/java/org/apache/arrow/memory/rounding/DefaultRoundingPolicy.java:
##########
@@ -34,13 +34,13 @@ public class DefaultRoundingPolicy implements
RoundingPolicy {
*
* <p>It was copied from {@link io.netty.buffer.PooledByteBufAllocator}.
*/
- private static final int MIN_PAGE_SIZE = 4096;
+ private static final long MIN_PAGE_SIZE = 4096;
- private static final int MAX_CHUNK_SIZE = (int) (((long) Integer.MAX_VALUE +
1) / 2);
+ private static final long MAX_CHUNK_SIZE = Long.MAX_VALUE / 2;
Review Comment:
For now let's keep it as Integer.MAX_VALUE so the value is same as before
##########
java/memory/memory-core/src/main/java/org/apache/arrow/memory/AllocationReservation.java:
##########
Review Comment:
I would still expect to see `long getSizeLong`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
