alamb commented on code in PR #6288:
URL: https://github.com/apache/arrow-rs/pull/6288#discussion_r1758917562
##########
arrow-buffer/src/util/bit_mask.rs:
##########
@@ -30,35 +29,128 @@ pub fn set_bits(
offset_read: usize,
len: usize,
) -> usize {
+ assert!(offset_write + len <= write_data.len() * 8);
Review Comment:
Could you please document the units of `offset_write`, `offset_read` and
`len` ? Are they in terms of bits or bytes? (I think bits)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
