WillAyd commented on code in PR #596:
URL: https://github.com/apache/arrow-nanoarrow/pull/596#discussion_r1768916154


##########
src/nanoarrow/testing/testing.cc:
##########


Review Comment:
   OK no problem - I think will still keep the case statement for the DATA_VIEW 
enumeration that has been added - otherwise will get a warning during 
compilation
   
   ```
   ../src/nanoarrow/testing/testing.cc:1833:10: warning: enumeration value 
‘NANOARROW_BUFFER_TYPE_DATA_VIEW’ not handled in switch [-Wswitch]
    1833 |   switch (array_view->layout.buffer_type[buffer_i]) {
         |          ^
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscr...@arrow.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to