paleolimbot commented on code in PR #596:
URL: https://github.com/apache/arrow-nanoarrow/pull/596#discussion_r1766043764
##########
src/nanoarrow/common/array.c:
##########
@@ -642,6 +673,10 @@ void ArrowArrayViewReset(struct ArrowArrayView*
array_view) {
ArrowFree(array_view->union_type_id_map);
}
+ if (array_view->variadic_buffer_views != NULL) {
+ ArrowFree(array_view->variadic_buffer_views);
Review Comment:
I know you're still working here, but just a bump that I don't think we want
`array_view->variadic_buffer_view` to exist, since it will involve a
potentially very large allocation on `ArrowArrayViewSetArray()`. Those are
buffer views that we can materialize on demand by either adding
`ArrowBufferView ArrowArrayViewVariadicBuffer(array_view, i)` or
`ArrowArrayViewBuffer(array_view, i)`.
##########
python/tests/test_schema.py:
##########
@@ -107,6 +107,9 @@ def test_schema_simple():
assert na.interval_months().type == na.Type.INTERVAL_MONTHS
assert na.interval_day_time().type == na.Type.INTERVAL_DAY_TIME
assert na.interval_month_day_nano().type == na.Type.INTERVAL_MONTH_DAY_NANO
+ # TODO: run_end_encoded
+ assert na.binary_view().type == na.Type.BINARY_VIEW
Review Comment:
```suggestion
assert na.binary_view().type == na.Type.BINARY_VIEW
```
(we have an issue for this one, feel free to punt!
https://github.com/apache/arrow-nanoarrow/issues/618)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@arrow.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
