birschick-bq commented on code in PR #2152:
URL: https://github.com/apache/arrow-adbc/pull/2152#discussion_r1775574130
##########
csharp/test/Drivers/Apache/Spark/StringValueTests.cs:
##########
@@ -50,11 +50,11 @@ public static IEnumerable<object[]> ByteArrayData(int size)
[InlineData(null)]
[InlineData("")]
[InlineData("你好")]
- [InlineData("String contains formatting characters tab\t, newline\n,
carriage return\r.", "3.4.0")]
+ [InlineData("String contains formatting characters tab\t, newline\n,
carriage return\r.", SparkServerType.Databricks)]
[InlineData(" Leading and trailing spaces ")]
- public async Task TestStringData(string? value, string? minVersion =
null)
+ internal async Task TestStringData(string? value, SparkServerType?
serverType = default)
Review Comment:
Yes. No problem with this framework. A side effect of making
`SparkServerType` internal.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@arrow.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
