kou commented on code in PR #44659:
URL: https://github.com/apache/arrow/pull/44659#discussion_r1830759019
##########
c_glib/arrow-glib/basic-data-type.cpp:
##########
@@ -813,6 +815,35 @@ garrow_binary_data_type_new(void)
return data_type;
}
+G_DEFINE_TYPE(GArrowBinaryViewDataType,
+ garrow_binary_view_data_type,
+ GARROW_TYPE_DATA_TYPE)
+
+static void
+garrow_binary_view_data_type_init(GArrowBinaryViewDataType *object)
+{
+}
+
+static void
+garrow_binary_view_data_type_class_init(GArrowBinaryViewDataTypeClass *klass)
+{
+}
+
+/**
+ * garrow_binary_view_data_type_new:
+ *
+ * Returns: The newly created binary view data type.
+ */
+GArrowBinaryViewDataType *
+garrow_binary_view_data_type_new(void)
+{
+ auto arrow_data_type = arrow::binary_view();
+
Review Comment:
```suggestion
```
##########
c_glib/arrow-glib/basic-data-type.cpp:
##########
@@ -69,6 +69,8 @@ G_BEGIN_DECLS
*
* #GArrowBinaryDataType is a class for the binary data type.
*
+ * #GArrowBinaryViewDataType is a class for the binary data type.
Review Comment:
```suggestion
* #GArrowBinaryViewDataType is a class for the binary view data type.
```
Anyway, could you move this to
https://github.com/apache/arrow/blob/40b2fca4742e2692a917755fd8db2939e10fa02d/c_glib/arrow-glib/basic-data-type.cpp#L130
?
##########
c_glib/arrow-glib/basic-data-type.h:
##########
@@ -418,6 +418,22 @@ struct _GArrowTemporalDataTypeClass
GArrowFixedWidthDataTypeClass parent_class;
};
+#define GARROW_TYPE_BINARY_VIEW_DATA_TYPE
(garrow_binary_view_data_type_get_type())
+GARROW_AVAILABLE_IN_19_0
+G_DECLARE_DERIVABLE_TYPE(GArrowBinaryViewDataType,
+ garrow_binary_view_data_type,
+ GARROW,
+ BINARY_VIEW_DATA_TYPE,
+ GArrowDataType)
+struct _GArrowBinaryViewDataTypeClass
+{
+ GArrowDataTypeClass parent_class;
+};
+
+GARROW_AVAILABLE_IN_19_0
+GArrowBinaryViewDataType *
+garrow_binary_view_data_type_new(void);
Review Comment:
Could you move this to
https://github.com/apache/arrow/blob/40b2fca4742e2692a917755fd8db2939e10fa02d/c_glib/arrow-glib/basic-data-type.h#L772
?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
