kou commented on code in PR #44659: URL: https://github.com/apache/arrow/pull/44659#discussion_r1831714365
########## c_glib/arrow-glib/basic-data-type.h: ########## @@ -418,6 +418,22 @@ struct _GArrowTemporalDataTypeClass GArrowFixedWidthDataTypeClass parent_class; }; +#define GARROW_TYPE_BINARY_VIEW_DATA_TYPE (garrow_binary_view_data_type_get_type()) Review Comment: Yes. `#define GARROW_TYPE_...` should be near the related `G_DECLARE_DERIVABLE_TYPE()` and so on. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
