kou commented on PR #44704:
URL: https://github.com/apache/arrow/pull/44704#issuecomment-2475119847
If we use `[0-9]+.[0-9]+.[0-9]+`, we can't detect wrong version number. For
example, `20.0.0` is also accepted when `19.0.0` is expected.
How about adding a new variable for `MAJOR.MINOR.PATCH` only version?
```diff
diff --git a/dev/archery/archery/crossbow/core.py
b/dev/archery/archery/crossbow/core.py
index 12571c0ff6..ea6ba31fb8 100644
--- a/dev/archery/archery/crossbow/core.py
+++ b/dev/archery/archery/crossbow/core.py
@@ -803,6 +803,11 @@ class Target(Serializable):
self.r_version = r_version
self.no_rc_version = re.sub(r'-rc\d+\Z', '', version)
self.no_rc_r_version = re.sub(r'-rc\d+\Z', '', r_version)
+ # Example:
+ #
+ # '19.0.0.dev66' ->
+ # '19.0.0'
+ self.no_rc_no_dev_version = (r'\.(dev\d+)\Z', '',
self.no_rc_version)
# Semantic Versioning 1.0.0: https://semver.org/spec/v1.0.0.html
#
# > A pre-release version number MAY be denoted by appending an
@@ -1195,6 +1200,7 @@ class Job(Serializable):
versions = {
'version': target.version,
'no_rc_version': target.no_rc_version,
+ 'no_rc_no_dev_version': target.no_rc_version,
'no_rc_semver_version': target.no_rc_semver_version,
'no_rc_snapshot_version': target.no_rc_snapshot_version,
'r_version': target.r_version,
diff --git a/dev/tasks/tasks.yml b/dev/tasks/tasks.yml
index 31d260bbfd..12dcfc1edd 100644
--- a/dev/tasks/tasks.yml
+++ b/dev/tasks/tasks.yml
@@ -693,7 +693,7 @@ tasks:
ci: github
template: matlab/github.yml
artifacts:
- - matlab-arrow-{no_rc_version}.mltbx
+ - matlab-arrow-{no_rc_no_dev_version}.mltbx
############################## Arrow JAR's
##################################
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
