tustvold commented on code in PR #6738:
URL: https://github.com/apache/arrow-rs/pull/6738#discussion_r1847940226
##########
parquet/src/schema/types.rs:
##########
@@ -1227,6 +1231,10 @@ fn from_thrift_helper(elements: &[SchemaElement], index:
usize) -> Result<(usize
if !is_root_node {
builder = builder.with_repetition(rep);
}
+ } else if !is_root_node {
Review Comment:
My concern with this check is unless it is necessary for correctness, there
is potential adding it breaks something for someone. Parquet is a very broad
ecosystem, lots of writers have interesting interpretations of the specification
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
