ianmcook commented on a change in pull request #9716:
URL: https://github.com/apache/arrow/pull/9716#discussion_r595456986
##########
File path: r/R/dplyr.R
##########
@@ -42,7 +42,10 @@ arrow_dplyr_query <- function(.data) {
filtered_rows = TRUE,
# group_by_vars is a character vector of columns (as renamed)
# in the data. They will be kept when data is pulled into R.
- group_by_vars = character()
+ group_by_vars = character(),
+ # drop_empty_groups is a logical value indicating whether to drop
+ # groups formed by factor levels that don't appear in the data
+ drop_empty_groups = TRUE
Review comment:
Yeah this was bothering me too that the default value of `TRUE` was set
in multiple places in the code like this, and that it is set when the data is
not grouped. I will change it to `NULL` which is effectively the same as not
setting it at all but I assume it's best to still show it here.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
