pitrou commented on code in PR #44796:
URL: https://github.com/apache/arrow/pull/44796#discussion_r1850598909
##########
cpp/src/arrow/ipc/json_simple_test.cc:
##########
@@ -857,7 +857,8 @@ TEST(TestMap, StringToInteger) {
ASSERT_OK_AND_ASSIGN(auto expected_keys,
ArrayFromJSON(utf8(), R"(["joe", "mark", "cap"])"));
ASSERT_OK_AND_ASSIGN(auto expected_values, ArrayFromJSON(int32(), "[0, null,
8]"));
- ASSERT_OK_AND_ASSIGN(auto expected_null_bitmap, BytesToBits({1, 0, 1, 1}));
+ uint8_t bitmap_bytes[] = {1, 0, 1, 1};
+ ASSERT_OK_AND_ASSIGN(auto expected_null_bitmap,
BytesToBits(util::span(bitmap_bytes)));
Review Comment:
Same here?
```suggestion
ASSERT_OK_AND_ASSIGN(auto expected_null_bitmap, std::vector<uint8_t>({1,
0, 1, 1}));
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
