mapleFU commented on code in PR #44849:
URL: https://github.com/apache/arrow/pull/44849#discussion_r1856937013
##########
cpp/src/arrow/acero/concurrent_queue_internal.h:
##########
@@ -65,17 +65,19 @@ class ConcurrentQueue {
return queue_.empty();
}
- // Un-synchronized access to front
- // For this to be "safe":
- // 1) the caller logically guarantees that queue is not empty
- // 2) pop/try_pop cannot be called concurrently with this
- const T& UnsyncFront() const { return queue_.front(); }
-
- size_t UnsyncSize() const { return queue_.size(); }
+ const T& Front() const {
+ // Need to lock the queue because `front()` may be implemented in terms
+ // of `begin()`, which isn't safe with concurrent calls to e.g. `push()`.
Review Comment:
is this `push` means `deque::push_back/front` or `ConcurrentQueue::Push()`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
