wgtmac commented on code in PR #40594:
URL: https://github.com/apache/arrow/pull/40594#discussion_r1857674773
##########
cpp/src/parquet/encoder.cc:
##########
@@ -170,6 +179,7 @@ template <typename DType>
void PlainEncoder<DType>::Put(const T* buffer, int num_values) {
if (num_values > 0) {
PARQUET_THROW_NOT_OK(sink_.Append(buffer, num_values * sizeof(T)));
+ unencoded_data_bytes_ += num_values * sizeof(T);
Review Comment:
Yes, I think it is pretty straight-forward to implement other types. I don't
want to add a byte array specific function or variable to the generic `Encoder`
and `EncoderImpl` classes, which is ugly.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
