cyb70289 commented on a change in pull request #9728:
URL: https://github.com/apache/arrow/pull/9728#discussion_r596522463
##########
File path: cpp/src/arrow/flight/client.h
##########
@@ -94,8 +94,6 @@ class ARROW_FLIGHT_EXPORT FlightWriteSizeStatusDetail :
public arrow::StatusDeta
class ARROW_FLIGHT_EXPORT FlightClientOptions {
public:
- FlightClientOptions();
Review comment:
I declared default constructor as private and find it's called
implicitly at line
https://github.com/apache/arrow/blob/master/cpp/src/arrow/flight/client.cc#L1243,
the second augment `{}`.
Default constructor creates invalid object now, should not be accidentally
called.
Maybe add a constructor with explicit parameters?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
