bkietz commented on a change in pull request #9715:
URL: https://github.com/apache/arrow/pull/9715#discussion_r597074339
##########
File path: cpp/src/arrow/testing/random.h
##########
@@ -358,6 +362,10 @@ class ARROW_TESTING_EXPORT RandomArrayGenerator {
std::default_random_engine seed_rng_;
};
+ARROW_TESTING_EXPORT
+std::shared_ptr<arrow::RecordBatch> Generate(const FieldVector& fields,
int64_t size,
+ SeedType seed);
Review comment:
SGTM. The explicit seed argument isn't the end of the world either; feel
free to leave it
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
