cyb70289 commented on a change in pull request #9746:
URL: https://github.com/apache/arrow/pull/9746#discussion_r597341591
##########
File path: cpp/src/arrow/flight/CMakeLists.txt
##########
@@ -83,7 +83,7 @@ function(test_grpc_version DST_VAR DETECT_VERSION TEST_FILE)
try_compile(HAS_GRPC_VERSION ${CMAKE_CURRENT_BINARY_DIR}/try_compile
SOURCES
"${CMAKE_CURRENT_SOURCE_DIR}/try_compile/${TEST_FILE}"
CMAKE_FLAGS
"-DINCLUDE_DIRECTORIES=${CURRENT_INCLUDE_DIRECTORIES}"
- LINK_LIBRARIES gRPC::grpc gRPC::grpc++
+ LINK_LIBRARIES ${GRPC_STATIC_LIBRARY_GRPCPP} gRPC::grpc
gRPC::gpr gRPC::upb gRPC::address_sorting ${ABSL_LIBRARIES} ${ABSL_LIBRARIES}
-pthread
Review comment:
The ABSL libs is kind of tricky. I did managed to make compiler happy by
re-arranging the libs, and looks there're circular depends of these libs.
Don't know if ABSL has recommended way to link the bunches of libs (why not
just provide a single .a?)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
