alamb opened a new pull request, #6886:
URL: https://github.com/apache/arrow-rs/pull/6886
# Which issue does this PR close?
<!--
We generally require a GitHub issue to be filed for all bug fixes and
enhancements and this helps us generate change logs for our releases. You can
link an issue to this PR using the GitHub syntax. For example `Closes #123`
indicates that this PR will close issue #123.
-->
Closes #.
# Rationale for this change
While working on https://github.com/apache/arrow-rs/pull/6840 the `fmt` ci
check failed on parquet. For example:
https://github.com/apache/arrow-rs/actions/runs/12361198145/job/34497838320
```
Run cargo fmt -p parquet -- --check --config skip_children=true `find .
-name "*.rs" \! -name format.rs`
Diff in
/__w/arrow-rs/arrow-rs/parquet/src/arrow/schema/mod.rs:1[7](https://github.com/apache/arrow-rs/actions/runs/12361198145/job/34497838320#step:7:8)75:
Field::new("decimal256", DataType::Decimal256(39, 2), false),
];
let arrow_schema = Schema::new(arrow_fields);
- let converted_arrow_schema = ArrowSchemaConverter::new()
- .convert(&arrow_schema)
- .unwrap();
+ let converted_arrow_schema =
ArrowSchemaConverter::new().convert(&arrow_schema).unwrap();
assert_eq!(
parquet_schema.columns().len(),
Error: Process completed with exit code 1.
```
However, the exact recipe to fix this was not clear (you have to run a
certain command within the arquet directory)
# What changes are included in this PR?
1. Add the commands needed to fix CI as comments in the script so they are
visible in the failure
Example
XXX
# Are there any user-facing changes?
<!--
If there are user-facing changes then we may require documentation to be
updated before approving the PR.
-->
<!---
If there are any breaking changes to public APIs, please call them out.
-->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
