etseidl commented on code in PR #6886:
URL: https://github.com/apache/arrow-rs/pull/6886#discussion_r1887747518
##########
.github/workflows/rust.yml:
##########
@@ -101,12 +101,13 @@ jobs:
- name: Format arrow
run: cargo fmt --all -- --check
- name: Format parquet
- # Many modules in parquet are skipped, so check parquet separately. If
this check fails, run:
- # cargo fmt -p parquet -- --config skip_children=true `find
./parquet -name "*.rs" \! -name format.rs`
- # from the top level arrow-rs directory and check in the result.
+ # Many modules in parquet are skipped, so check parquet separately
# https://github.com/apache/arrow-rs/issues/6179
working-directory: parquet
- run: cargo fmt -p parquet -- --check --config skip_children=true `find
. -name "*.rs" \! -name format.rs`
+ run: |
+ # if this fails, run this from the parquet directory:
+ # cargo fmt -p parquet -- --config skip_children=true `find
./parquet -name "*.rs" \! -name format.rs`
Review Comment:
If running from the parquet directory, then just '.' for the find path:
```suggestion
# if this fails, run this from the parquet directory:
# cargo fmt -p parquet -- --config skip_children=true `find .
-name "*.rs" \! -name format.rs`
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
