tustvold commented on code in PR #6893:
URL: https://github.com/apache/arrow-rs/pull/6893#discussion_r1889285839
##########
arrow-buffer/src/buffer/offset.rs:
##########
@@ -184,6 +223,119 @@ impl<O: ArrowNativeType> From<OffsetBufferBuilder<O>> for
OffsetBuffer<O> {
}
}
+struct MergeBuffersIter<'a, Offset: Integer + Copy> {
Review Comment:
This seems exceptionally complicated for what it is doing, see above for how
this could be achieved with a lot less complexity
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
