tustvold commented on code in PR #6893:
URL: https://github.com/apache/arrow-rs/pull/6893#discussion_r1889291117
##########
arrow-select/src/concat.rs:
##########
@@ -129,12 +130,106 @@ fn concat_dictionaries<K: ArrowDictionaryKeyType>(
Ok(Arc::new(array))
}
+fn concat_list_of_dictionaries<OffsetSize: OffsetSizeTrait, K:
ArrowDictionaryKeyType>(
Review Comment:
It would significantly reduce the codegen to instead split concatenating the
dictionary values, from re-encoding the offsets. As an added bonus this could
also be done recursively.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
