raulcd commented on code in PR #45064:
URL: https://github.com/apache/arrow/pull/45064#discussion_r1890153185
##########
cpp/cmake_modules/ThirdpartyToolchain.cmake:
##########
@@ -2990,30 +3011,40 @@ macro(build_absl)
statusor
str_format_internal
strerror
+ string_view
strings
strings_internal
symbolize
synchronization
throw_delegate
time
time_zone
- wyhash)
+ utf8_for_code_point
+ vlog_config_internal)
# Abseil creates a number of header-only targets, which are needed to
resolve dependencies.
# The list can be refreshed using:
- # comm -13 <(ls -l $PREFIX/lib/libabsl_*.a | sed -e 's/.*libabsl_//' -e
's/.a$//' | sort -u) \
- # <(ls -1 $PREFIX/lib/pkgconfig/absl_*.pc | sed -e 's/.*absl_//'
-e 's/.pc$//' | sort -u)
+ # comm -13 <(ls -l lib/libabsl_*.a | sed -e 's/.*libabsl_//' -e 's/.a$//'
| sort -u) \
+ # <(ls -1 lib/pkgconfig/absl_*.pc | sed -e 's/.*absl_//' -e
's/.pc$//' | sort -u)
set(_ABSL_INTERFACE_LIBS
+ absl::check
+ absl::log
+ absl::vlog_is_on
Review Comment:
Those three weren't picked by the command but were necessary to build
##########
cpp/cmake_modules/ThirdpartyToolchain.cmake:
##########
@@ -3948,11 +4382,13 @@ macro(build_grpc)
GRPC_C_FLAGS
" -Wno-attributes"
" -Wno-format-security"
+ " -Wno-return-type"
Review Comment:
I had to add those to avoid a bunch of those:
```
/build/cpp/grpc_ep-prefix/src/grpc_ep/src/core/lib/promise/party.h: In
member function 'grpc_core::Poll<typename
grpc_core::promise_detail::OncePromiseFactory<void, F>::Promise::Result>
grpc_core::Party::PromiseParticipantImpl<SuppliedFactory>::PollCompletion()
[with SuppliedFactory = grpc_core::ForwardCall(grpc_core::CallHandler,
grpc_core::CallInitiator,
absl::lts_20240722::AnyInvocable<void(grpc_metadata_batch&)>)::<lambda()>
mutable::<lambda(std::optional<std::unique_ptr<grpc_metadata_batch,
grpc_core::Arena::PooledDeleter> >)> mutable::<lambda()>
mutable::<lambda(grpc_core::MessageHandle)> mutable::<lambda()>]':
/build/cpp/grpc_ep-prefix/src/grpc_ep/src/core/lib/promise/party.h:284:5:
warning: control reaches end of non-void function [-Wreturn-type]
284 | }
| ^
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
