emkornfield commented on code in PR #6738:
URL: https://github.com/apache/arrow-rs/pull/6738#discussion_r1892471128
##########
parquet/src/thrift.rs:
##########
@@ -67,7 +67,7 @@ impl<'a> TCompactSliceInputProtocol<'a> {
let mut shift = 0;
loop {
let byte = self.read_byte()?;
- in_progress |= ((byte & 0x7F) as u64) << shift;
+ in_progress |= ((byte & 0x7F) as u64).wrapping_shl(shift);
Review Comment:
I might be misunderstanding but I thoght shifting by 63 bits is well defined
on u64? So overflow yes but I wouldn't expect a panic? Also I think silently
passing here if there is an overflow would be data corrupt data?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
