alamb commented on code in PR #6738:
URL: https://github.com/apache/arrow-rs/pull/6738#discussion_r1890200442
##########
parquet/src/thrift.rs:
##########
@@ -67,7 +67,7 @@ impl<'a> TCompactSliceInputProtocol<'a> {
let mut shift = 0;
loop {
let byte = self.read_byte()?;
- in_progress |= ((byte & 0x7F) as u64) << shift;
+ in_progress |= ((byte & 0x7F) as u64).wrapping_shl(shift);
Review Comment:
What is the purpose of this change?
As I understand it `<<` panics in debug builds on overflow but wraps in
release builds
It seems to me that this change now avoids panic'ing in debug builds too,
which isn't obviously better to me
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
