himadripal commented on PR #6905: URL: https://github.com/apache/arrow-rs/pull/6905#issuecomment-2563090408
> This PR seems to remove a number of tests, and orphan some others. If we're changing what cast does, can we please remove the old implementation and port the old tests, so that we aren't losing test coverage. > > Also as written this PR is a breaking change, as it alters the rounding behaviour of the parser. Thanks @tustvold I've moved over most of the tests for `parse_string_to_decimal_native` to use parse_decimal whichever is not already covered by another test. let me know if I've missed anything. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
