andygrove commented on code in PR #6905:
URL: https://github.com/apache/arrow-rs/pull/6905#discussion_r1901339434
##########
arrow-csv/src/reader/mod.rs:
##########
@@ -1284,7 +1284,7 @@ mod tests {
assert_eq!("53.002666", lat.value_as_string(1));
assert_eq!("52.412811", lat.value_as_string(2));
assert_eq!("51.481583", lat.value_as_string(3));
- assert_eq!("12.123456", lat.value_as_string(4));
+ assert_eq!("12.123457", lat.value_as_string(4));
Review Comment:
There is an argument for accepting the breaking change to use rounding since
it would be consistent with how we cast floating point to decimal. However, do
we want to consider adding a parameter to choose between truncation and
rounding?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
