WillAyd commented on code in PR #44195:
URL: https://github.com/apache/arrow/pull/44195#discussion_r1901834831
##########
python/pyarrow/pandas_compat.py:
##########
@@ -174,7 +174,11 @@ def get_column_metadata(column, name, arrow_type,
field_name):
}
string_dtype = 'object'
- if name is not None and not isinstance(name, str):
+ if (
+ name is not None
+ and not (isinstance(name, float) and np.isnan(name))
Review Comment:
Does this mean that np.nan is now a valid column name for the string data
type?
##########
python/pyarrow/src/arrow/python/arrow_to_pandas.cc:
##########
@@ -2523,7 +2523,8 @@ Status ConvertCategoricals(const PandasOptions& options,
ChunkedArrayVector* arr
}
if (options.strings_to_categorical) {
for (int i = 0; i < static_cast<int>(arrays->size()); i++) {
- if (is_base_binary_like((*arrays)[i]->type()->id())) {
+ if (is_base_binary_like((*arrays)[i]->type()->id()) ||
Review Comment:
The binary_view changes are tangential to pandas 3.x right? I wonder if they
shouldn't be done in their own PR
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
