WillAyd commented on code in PR #44195:
URL: https://github.com/apache/arrow/pull/44195#discussion_r1901875631
##########
python/pyarrow/src/arrow/python/arrow_to_pandas.cc:
##########
@@ -2523,7 +2523,8 @@ Status ConvertCategoricals(const PandasOptions& options,
ChunkedArrayVector* arr
}
if (options.strings_to_categorical) {
for (int i = 0; i < static_cast<int>(arrays->size()); i++) {
- if (is_base_binary_like((*arrays)[i]->type()->id())) {
+ if (is_base_binary_like((*arrays)[i]->type()->id()) ||
Review Comment:
Yea I would prefer to separate out so we can analyze test coverage too. I
suppose that would also be helpful if these changes end up going through to
different releases (although that's not the aim)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
