adamreeve commented on code in PR #6953:
URL: https://github.com/apache/arrow-rs/pull/6953#discussion_r1906448875
##########
parquet/src/util/interner.rs:
##########
@@ -66,7 +70,7 @@ impl<S: Storage> Interner<S> {
.dedup
.entry(
hash,
- |index| value == self.storage.get(*index),
+ |index| value.eq(self.storage.get(*index)),
Review Comment:
Hmm, after opening this PR I realised a simpler approach would be to just
compare the values by their byte representation here:
```rust
|index| value.as_bytes() == self.storage.get(*index).as_bytes()
```
I will check what effect that has on performance.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
