alamb commented on PR #6953: URL: https://github.com/apache/arrow-rs/pull/6953#issuecomment-2590103438
> > I think technically speaking this could be a behavior change as previously different Nan representations would be collapsed into a single dictionary entry, but now they will use different entries. > > I don't think this is true as the `NaN == NaN` test being false would have caused all NaN values to get separate entries in the dictionary, so behaviour shouldn't have changed. But it does differ from C++ Arrow which does collapse all NaNs to a single entry. I feel like there must be semantic difference between comparing Nans using .eq and comparing the bit patterns 🤔 However, I suppose at this point it is just an intellectual execise 🤷 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
